feat: add full disk volumes #12104
Draft
feat: add full disk volumes #12104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanduur
force-pushed
the
lvm-volumes
branch
2 times, most recently
from
7681083 to
6cf202a
Compare
shanduur
commented
Oct 30, 2025
| // TestUserVolumesBind performs a series of operations on user volumes (bind type): creating, destroying, verifying, etc. | ||
| func (suite *VolumesSuite) TestUserVolumesBind() { | ||
| // TestUserVolumesDisk performs a series of operations on user volumes (disk type): creating, destroying, verifying, etc. | ||
| func (suite *VolumesSuite) TestUserVolumesDisk() { |
There was a problem hiding this comment.
There needs to be another test for LVM instead of raw disk.
shanduur
force-pushed
the
lvm-volumes
branch
15 times, most recently
from
8ff66bd to
2f08270
Compare
When set to `disk`, a full block device is used for the volume. When `volumeType = "disk"`: - Size specific settings are not allowed in the provisioning block (`minSize`, `maxSize`, `grow`). Signed-off-by: Mateusz Urbanek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
volumeTypein UserVolumeConfig can be set todisk.When set to
disk, a full block device is used for the volume.When
volumeType = "disk":minSize,maxSize,grow).