Skip to content

fix: improve OOM controller stability and make test strict on false positives #12107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve OOM controller stability and make test strict on false positives #12107

wants to merge 1 commit into from
+104 −40

Conversation

@dsseng
Copy link
Member

@dsseng dsseng commented Oct 30, 2025 •
edited
Loading

  • Add d_* PSI derivative values to the trigger expression context
  • Only trigger OOM action while PSI is rising
  • Make OOM test fail if controller kills a cgroup without stress-ng

Fixes #12077

@github-project-automation github-project-automation bot moved this to To Do in Planning Oct 30, 2025
@talos-bot talos-bot moved this from To Do to In Review in Planning Oct 30, 2025
smira
smira approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@github-project-automation github-project-automation bot moved this from In Review to Approved in Planning Oct 30, 2025
@dsseng dsseng force-pushed the fix-oom-false-pos branch from 79bffbc to 6dcb6a6 Compare October 30, 2025 17:25
@dsseng dsseng added the integration/qemu-race QEMU w/ race detector label Oct 30, 2025
@dsseng dsseng force-pushed the fix-oom-false-pos branch from 6dcb6a6 to 5974db3 Compare October 30, 2025 21:08
@dsseng dsseng force-pushed the fix-oom-false-pos branch 3 times, most recently from 28262f6 to 828fc72 Compare October 31, 2025 17:18
@dsseng
fix: improve OOM controller stability and make test strict on false p…
49c5e9f 
…ositives

- Add d_* PSI derivative values to the trigger expression context
- Only trigger OOM action while PSI is rising
- Make OOM test fail if controller kills a cgroup without stress-ng
- Skip OOM test when running with race detector

Signed-off-by: Dmitrii Sharshakov <[email protected]>
@dsseng dsseng force-pushed the fix-oom-false-pos branch from 828fc72 to 49c5e9f Compare November 3, 2025 08:40
@smira
Copy link
Member

smira commented Nov 5, 2025

I don't know if we should relax our assertions a bit by allowing non-stressng kills?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smira smira smira approved these changes

@frezbo frezbo frezbo approved these changes

Assignees

No one assigned

Labels

integration/qemu integration/qemu-enforcing QEMU (all tests) + SELinux integration/qemu-race QEMU w/ race detector status/ok-to-test

Projects

Planning
Status: Approved

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

improve cooldown of OOM trigger

4 participants

@dsseng @smira @frezbo @talos-bot