Add objectBaseClass option which can be set to Object instead of null to keep prototype methods like hasOwnProperty#47
Open
klesun wants to merge 1 commit intosidorares:masterfrom
Open
Conversation
…`null` to preserve prototype methods like `hasOwnProperty` sidorares#38
objectBaseClass option which can be set to Object instead of null to preserve prototype methods like hasOwnPropertyobjectBaseClass option which can be set to Object instead of null to keep prototype methods like hasOwnProperty
corrigancd
added a commit
to sirensolutions/json-bigint
that referenced
this pull request
Jul 14, 2021
Adding fix to forked repo - sidorares#47
2 tasks
|
Anything stopping this being merged?? |
Ah because it doesn't actually do anything! The 'objectBaseClass' option isn't actually applied to the I've just opened #64 with a similar fix. It won't let you provide an arbitrary prototype for the parsed objects, but it will let you choose between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #38, after the c85a430 (
v1.0.0) base class for parsed objects is nownullrather thanObject. This differs from theJSON.parse()behaviour and breaks compatibility for codebases that are using prototype methods likehasOwnProperty().By specifying the
objectBaseClassoption introduced in this PR, users of the lib will be able to use it even in a code that relies on parsed object to havehasOwnProperty,toStringand other prototype methods:Closes #39, #38