fix(promise): forward pool error events - #4487
Open
GiHoon1123 wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4487 +/- ##
=======================================
Coverage 92.50% 92.51%
=======================================
Files 93 93
Lines 15909 15915 +6
Branches 2275 2275
=======================================
+ Hits 14717 14723 +6
Misses 1192 1192
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wellwelwel
approved these changes
Aug 23, 2026
Owner
|
@wellwelwel don't merge just yet. Wanted to check first that pool tracks idle connection errors at all - that might be not the case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3749
Promise pools inherit lifecycle events from the underlying core pool, but the error event was not forwarded and was not exposed in the promise pool types.
This adds error to the forwarded pool events and adds a matching
pool.on('error', ...)overload for the promise API. The existing promise wrapper event test now covers error forwarding, and the TypeScript build tests cover the promise pool event signature.Tests:
npm run typechecknpm run lintnpm run test:build