Adding session import/export - #183
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d16a82998
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (const candidate of this.candidates) { | ||
| if (candidate.eliminated) { | ||
| continue; | ||
| } | ||
| const matches = this.analyzer.verifyMatch(word, candidate.pattern); | ||
|
|
||
| if (matches) { |
There was a problem hiding this comment.
This loop now updates votes for all candidates (including eliminated ones), but recalculateVotes() still skips eliminated candidates when replaying history. That means any action that triggers a replay (e.g., updateClassification or refineCandidates) will silently drop the post‑elimination vote updates you just added here, leading to different vote totals and potentially different final selections/exports after an edit. To avoid this divergence, recalculateVotes() should mirror the new behavior and keep updating eliminated candidates too.
Useful? React with 👍 / 👎.
1 participant
Adding session import/export for externalization,reproducability.