refactor: header component #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chintankavathia
force-pushed
the
refactor/header
branch
from
e336a1d to
5b492f6
Compare
removed unnecessary transform calculations for scrolling header along with body scroll.
chintankavathia
force-pushed
the
refactor/header
branch
from
5b492f6 to
dd8858b
Compare
|
I guess the better solution here would, to just use the same scrollbar for body and header. Then we can get rid of all that stuff |
We have vertical scroll which needs to be only on body element. I cannot find any solution to have horizontal scroll common on header and body and vertical scroll only on body. 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed unnecessary transform calculations for scrolling header along with body scroll.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: