fix: do not allow focusing of cell when not in cell selection mode #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Killusions
force-pushed
the
fix/do-not-allow-focusing-of-cell-when-not-in-cell-selection-mode
branch
from
2bcfcc2 to
1a6b5f2
Compare
fh1ch
requested review from
timowolf,
kfenner,
fh1ch and
spike-rabbit
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Currently, a cell can be focused by mouse, even when not in cell selectionMode, this creates an issue with focus styling and leads to the cell being selected by mouse instead of the row.
What is the new behavior?
Do not set tabindex=-1 on the cell if selectionMode is not cell, now clicking on a row focuses the entire row.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: