Skip to content

Conversation

chintankavathia
Copy link
Member

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@chintankavathia chintankavathia requested a review from a team as a code owner July 14, 2025 04:03
Copy link
Member

@fh1ch fh1ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chintankavathia thanks a lot for the PR, much appreciated 🙇

@spike-rabbit and myself discussed this briefly offline the other day and we see the introduction of Husky in this project as problematic:

  • It doesn't exist in the upstream project.
  • The project being a fork and on GitHub means there is enough Git proficiency around that people should be able to create correct commits/fix it if it isn't the case.
  • It's locally executed, we don't have any linting within CI at all ATM.
  • Husky is generally a bit problematic when it collides with Git LFS hooks, hence we're rather try to avoid using it when not really necesary.

Hence instead of adding Husky here, we should:

  • Introduce our usual lint:commit npm script for local and CI execution.
  • Use the lint:commit command within CI.

/cc @kfenner @timowolf

@fh1ch fh1ch added the enhancement New feature or request label Jul 16, 2025
@chintankavathia
Copy link
Member Author

@chintankavathia thanks a lot for the PR, much appreciated 🙇

@spike-rabbit and myself discussed this briefly offline the other day and we see the introduction of Husky in this project as problematic:

  • It doesn't exist in the upstream project.
  • The project being a fork and on GitHub means there is enough Git proficiency around that people should be able to create correct commits/fix it if it isn't the case.
  • It's locally executed, we don't have any linting within CI at all ATM.
  • Husky is generally a bit problematic when it collides with Git LFS hooks, hence we're rather try to avoid using it when not really necesary.

Hence instead of adding Husky here, we should:

  • Introduce our usual lint:commit npm script for local and CI execution.
  • Use the lint:commit command within CI.

/cc @kfenner @timowolf

The project being a fork and on GitHub means there is enough Git proficiency around that people should be able to create correct commits/fix it if it isn't the case. - I don't agree to assume people will follow correct commit formats if that is the case why would other libraries (angular, primeng) are using it 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants