refactor(row-wrapper): use signals for internals #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chintankavathia
force-pushed
the
refactor/row-wrapper/signals
branch
2 times, most recently
from
4cba1ad to
2b862a9
Compare
spike-rabbit
requested changes
Oct 1, 2025
| readonly ariaGroupHeaderCheckboxMessage = input.required<string>(); | ||
|
|
||
| context!: RowDetailContext<TRow> | GroupContext<TRow>; | ||
| readonly context = linkedSignal<RowDetailContext<TRow> | GroupContext<TRow>>(() => { |
There was a problem hiding this comment.
I guess this can a computed
There was a problem hiding this comment.
As I mentioned here #347 (comment)
computed won't trigger with markForCheck()
Comment on lines
-144
to
146
| if (this.rowDiffer.diff(this.row)) { | ||
| if ('group' in this.context) { | ||
| this.context.group = this.row as Group<TRow>; | ||
| const row = this.row(); | ||
| if (this.rowDiffer.diff(row)) { | ||
| if ('group' in this.context()) { | ||
| this.context.set({ | ||
| group: row as Group<TRow>, | ||
| expanded: this.expanded(), | ||
| rowIndex: this.rowIndex() | ||
| }); | ||
| } else { | ||
| this.context.row = this.row as TRow; | ||
| this.context.set({ | ||
| row: row as TRow, | ||
| expanded: this.expanded(), | ||
| rowIndex: this.rowIndex(), | ||
| disabled: this.disabled() | ||
| }); | ||
| } | ||
| this.cd.markForCheck(); | ||
| } |
There was a problem hiding this comment.
I think you can just do:
if (this.rowDiffer.diff(this.row)) {
this.cd.markForCheck();
}
projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.ts
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.ts
Outdated
Show resolved
Hide resolved
chintankavathia
force-pushed
the
refactor/row-wrapper/signals
branch
from
2b862a9 to
de24043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: