Added glyph rendering capability using go-text/typesetting#339
Open
netDinger wants to merge 5 commits intosignintech:masterfrom
Open
Added glyph rendering capability using go-text/typesetting#339netDinger wants to merge 5 commits intosignintech:masterfrom
netDinger wants to merge 5 commits intosignintech:masterfrom
Conversation
Collaborator
|
Hi, I should be free to review the code this weekend. |
oneplus1000
reviewed
Nov 1, 2025
oneplus1000
reviewed
Nov 16, 2025
| } else if err != nil { | ||
| return err | ||
| } | ||
| if c.charSpacing != 0 { |
Collaborator
There was a problem hiding this comment.
"If" there is something wrong here
| } | ||
|
|
||
| io.WriteString(w, ">] TJ\n") | ||
| io.WriteString(w, "ET\n") |
Author
There was a problem hiding this comment.
I have just fixed that. Kindly review my commit please.
Collaborator
|
You broke some of the old unittests. And I saw you removed the LiberationSerif-Regular.ttf font from repo. but that's not the point. The point is that even if brought the LiberationSerif-Regular.ttf font back, many unittests would still break. unitest in signintech:master
unitest in netDinger:feature/ligature-rendering
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the glyph rendering and ligatures rendering using go-text/typesetting.
Before:
After:
Issues:
go-text/typesetting#204
#293