refactor(peer_manager): modular peer manager #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Split monolithic peer_manager.rs into focused modules: - connection.rs: Connection management and limits - discovery.rs: Peer discovery and subnet-based selection - heartbeat.rs: Periodic heartbeat events and status reporting - types.rs: Common types and events - mod.rs: Main PeerManager coordination - Improve code organization and separation of concerns - Maintain existing functionality while improving maintainability - Each module has a single responsibility - Easier to test individual components - Follows same pattern as existing scoring/ module This refactor prepares the codebase for future peer blocking functionality while keeping the current implementation clean and modular.
diegomrsantos
force-pushed
the
refactor/modular-peer-manager
branch
2 times, most recently
from
147d165 to
b3ce3f4
Compare
dknopik
reviewed
Jul 16, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the monolithic peer_manager.rs into a modular structure with focused modules for better maintainability and separation of concerns. The refactor maintains all existing functionality while improving code organization.
- Splits peer manager into specialized modules: connection management, peer discovery, heartbeat events, and common types
- Introduces module-based architecture with
ConnectionManager,PeerDiscovery, andHeartbeatManagercomponents - Updates API method name from
discovered_peertoreport_discovered_peerfor clarity
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| anchor/network/src/peer_manager/mod.rs | Main peer manager module that coordinates all sub-components and implements NetworkBehaviour |
| anchor/network/src/peer_manager/types.rs | Defines common types like ConnectActions and Event used across modules |
| anchor/network/src/peer_manager/connection.rs | Manages peer connections and connection limits logic |
| anchor/network/src/peer_manager/discovery.rs | Handles peer discovery and subnet-based peer selection |
| anchor/network/src/peer_manager/heartbeat.rs | Manages periodic heartbeat events and status reporting |
| anchor/network/src/peer_manager.rs | Removes the original monolithic implementation |
| anchor/network/src/network.rs | Updates method call to use the new API name |
… of taking mutable reference
diegomrsantos
changed the title
|
@diegomrsantos Please merge using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR refactors the monolithic
peer_manager.rsinto a modular structure with focused modules for better maintainability and separation of concerns. The refactor maintains all existing functionality while improving code organization.