Underflow and Typo (#6885)

I was looking at sync and noticed a potential underflow and a typo, so just fixed those whilst I was in there.
sigp · Jan 30, 2025 · 1fe0ac7 · 1fe0ac7
1 parent d297d08
commit 1fe0ac7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/beacon_node/network/src/sync/peer_sync_info.rs b/beacon_node/network/src/sync/peer_sync_info.rs
@@ -30,8 +30,8 @@ pub fn remote_sync_type<T: BeaconChainTypes>(
 ) -> PeerSyncType {
     // auxiliary variables for clarity: Inclusive boundaries of the range in which we consider a peer's
     // head "near" ours.
-    let near_range_start = local.head_slot - SLOT_IMPORT_TOLERANCE as u64;
-    let near_range_end = local.head_slot + SLOT_IMPORT_TOLERANCE as u64;
+    let near_range_start = local.head_slot.saturating_sub(SLOT_IMPORT_TOLERANCE);
+    let near_range_end = local.head_slot.saturating_add(SLOT_IMPORT_TOLERANCE);
 
     match remote.finalized_epoch.cmp(&local.finalized_epoch) {
         Ordering::Less => {

diff --git a/beacon_node/network/src/sync/range_sync/chain_collection.rs b/beacon_node/network/src/sync/range_sync/chain_collection.rs
@@ -86,7 +86,7 @@ impl<T: BeaconChainTypes> ChainCollection<T> {
                         RangeSyncState::Head(syncing_head_ids)
                     };
                 } else {
-                    // we removed a head chain, or an stoped finalized chain
+                    // we removed a head chain, or a stopped finalized chain
                     debug_assert!(!was_syncing || sync_type != RangeSyncType::Finalized);
                 }
             }