Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate futures ticker #6630

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Deprecate futures ticker #6630

merged 9 commits into from
Dec 3, 2024

Conversation

hopinheimer
Copy link
Contributor

fixes #6622

@chong-he chong-he added ready-for-review The code is ready for review Networking labels Nov 29, 2024
jxs
jxs approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you address the Clippy issues?

@jxs jxs changed the title Deprecate futures timer Deprecate futures ticker Nov 30, 2024
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Dec 3, 2024
michaelsproul
michaelsproul approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too

@michaelsproul
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Dec 3, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at fec502d

mergify bot added a commit that referenced this pull request Dec 3, 2024
@mergify
Merge of #6630
8dfd533
This was referenced Dec 3, 2024
Closed
Merged
mergify bot added a commit that referenced this pull request Dec 3, 2024
@mergify
Merge of #6630
4f2d4e6
@mergify mergify bot mentioned this pull request Dec 3, 2024
Closed
5 tasks
@mergify mergify bot merged commit fec502d into sigp:unstable Dec 3, 2024
29 checks passed
AgeManning pushed a commit to AgeManning/lighthouse that referenced this pull request Dec 11, 2024
@hopinheimer @AgeManning
Deprecate futures ticker (sigp#6630)
6679d33 
* deprecate futures-ticker

* Merge branch 'unstable' of github.com:sigp/lighthouse into deprecate-futures-timer

* Merge branch 'unstable' into deprecate-futures-timer

* making the linter happy

* remove unrequired #[allow(unused_imports)]

* fixing minor issues

* merge commit

* minor fix

* clippy changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
Networking ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hopinheimer @michaelsproul @jxs @chong-he