Delete the block_cache
#8404
Open
Delete the block_cache
#8404
+28
−343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The
block_cachewas disabled by default for hindering performance. We have no plans to re-enable it, and likely a performant replacement would look somewhat different from what we have now.This PR deletes the
block_cacheimplementation entirely, achieving a slight simplification of our DB code, and also takes aim at thedo_atomically_with_block_and_blobs_cachemethod which IMO was overly complicated for little gain.Additional Info
TODO:
DataColumnCustodyInfo.do_atomically_with_block_and_blobs_cacheto something more appropriate.