add values to leases-cleanup job and webhook deployment #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: falcorocks <[email protected]>
Signed-off-by: falcorocks <[email protected]>
Signed-off-by: falcorocks <[email protected]>
Signed-off-by: falcorocks <[email protected]>
Signed-off-by: falcorocks <[email protected]>
falcorocks
changed the title
Signed-off-by: falcorocks <[email protected]>
falcorocks
changed the title
falcorocks
force-pushed
the
feat-best-practices-values
branch
2 times, most recently
from
e2017c2 to
a846b3d
Compare
Signed-off-by: falcorocks <[email protected]>
falcorocks
force-pushed
the
feat-best-practices-values
branch
from
a846b3d to
3edf674
Compare
falcorocks
force-pushed
the
feat-best-practices-values
branch
from
43b7c13 to
3edf674
Compare
it was introduced by mistake in sigstore@142e34b and it is actually breaking. use helm-schema -k additionalProperties when updating the schema Signed-off-by: falcorocks <[email protected]>
it was introduced by mistake in sigstore@142e34b and it is actually breaking Signed-off-by: falcorocks <[email protected]>
falcorocks
force-pushed
the
feat-best-practices-values
branch
5 times, most recently
from
9ad6eff to
a5ca1bc
Compare
Signed-off-by: falcorocks <[email protected]>
falcorocks
force-pushed
the
feat-best-practices-values
branch
from
a5ca1bc to
a8b34ab
Compare
to allow users to pass env variables through configmaps and secrets Signed-off-by: falcorocks <[email protected]>
falcorocks
changed the title
falcorocks
force-pushed
the
feat-best-practices-values
branch
2 times, most recently
from
8231ffe to
2544b33
Compare
hectorj2f
requested changes
Jan 27, 2025
falcorocks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
podSecurityContextpriorityClassresourcespriorityClassenvFromadditionalPropertiesrequiredhelm-schemagives for granted that all values in the values.yaml are required and should not allow additionalProperties, which is pretty inflexible. We should ask users to runhelm-schema -k additionalProperties,requiredto avoid this from happening again. The PR also adds a new CI workflow to check that the schema has been generated with these flags. I've tested a failure on purpose here by messing with the schema and it worked. Notice that this test is limited to the policy controller only in this PR, if we are happy we can expand the test to cover all charts later, this PR is already big enough IMO.Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.