Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge CLs from 2.1.x series #893

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Merge CLs from 2.1.x series #893

merged 3 commits into from
Feb 5, 2024

Conversation

woodruffw
Copy link
Member

This cherry-picks the release prep work from series/2.1.x back onto main.

Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw added the chore label Feb 4, 2024
@woodruffw woodruffw requested a review from jku February 4, 2024 10:34
@woodruffw woodruffw self-assigned this Feb 4, 2024
@jku
Copy link
Member

jku commented Feb 4, 2024

Am I correct that the release pipeline just allowed you to make releases to pypi from unprotected branches without review but branch protection now requires someone review the changes that have been already released to pypi? 🤔

That seems incorrect.

@woodruffw
Copy link
Member Author

Am I correct that the release pipeline just allowed you to make releases to pypi from unprotected branches without review but branch protection now requires someone review the changes that have been already released to pypi? 🤔

Yes. This seems completely backwards to me, and I'm not sure why it let me do the release unilaterally (there should at minimum have been a workflow signoff for release, but it didn't prompt me for that either).

I'm going to look at strengthening the branch rules here, and there may be some release protections we can add as well.

@woodruffw
Copy link
Member Author

Hmm, I don't have the ability to add additional restrictions here (I'm not a Sigstore org admin or a sigstore-python repo admin). I think this will probably need some Pulumi updates. I can look into that on Monday.

@jku jku merged commit 1712665 into main Feb 5, 2024
25 checks passed
@jku jku deleted the ww/merge-cl branch February 5, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants