Skip to content

Conversation

mtompset
Copy link
Contributor

@mtompset mtompset commented Jul 9, 2025

Upgrade from PHP 9.x to 12.x
Drop support for PHP 7.4
Remove deprecated attributes in phpunit.xml
Add logic to update $_ENV as putenv no longer updates it in PHPUnit 10+
Turned assertions to static function calls like they should be.

Mark Tompsett added 3 commits July 9, 2025 11:13
PHPUnit to version 12 and drop PHP 7.4 support
These attributes are not supported in PHPUnit 12:
    convertErrorsToExceptions="true"
    convertNoticesToExceptions="true"
    convertWarningsToExceptions="true"
Just removed them
* PHPUnit >=10 putenv() does not push to $_ENV.
  Revised putenv() function to do that.
* $this->assert... should be self::assert... because the
  assertion functions are static
@mtompset mtompset requested a review from a team July 9, 2025 15:32
@mtompset mtompset self-assigned this Jul 9, 2025
@mtompset mtompset requested review from briskt, forevermatt, hobbitronics and devon-sil and removed request for a team July 9, 2025 15:32
Copy link

sonarqubecloud bot commented Jul 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mtompset mtompset merged commit 8c594b4 into main Jul 9, 2025
2 checks passed
@mtompset mtompset deleted the feature/update-phpunit branch July 9, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants