Skip to content

Fixes for PHP 8.2 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fixes for PHP 8.2 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d522ab6
Amfphp_Core_Exception: fix Creation of dynamic property Amfphp_Core_E…
joshtynjala Sep 6, 2023
47435b1
AmfphpErrorHandler: fix Too few arguments to function custom_warning_…
joshtynjala Sep 6, 2023
b4a0400
AmfphpGet, AmfphpJson: Fix strpos(): Passing null to parameter #1 () …
joshtynjala Sep 6, 2023
210d666
AmfphpMonitor: check for null before calling substr()
joshtynjala Sep 6, 2023
b592d54
AcknowledgeMessage, ErrorMessage: fix Creation of dynamic property i…
joshtynjala Sep 6, 2023
d6a3e08
UserVO1 example: Fix Creation of dynamic property is deprecated
joshtynjala Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Amfphp/Core/Exception.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* @package Amfphp_Core
* @author Ariel Sommeria-klein
*/
#[AllowDynamicProperties]
class Amfphp_Core_Exception extends Exception {

}
Expand Down
2 changes: 1 addition & 1 deletion Amfphp/Plugins/AmfphpErrorHandler/AmfphpErrorHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function __construct(array $config = null) {
* @param mixed $errcontext
* @throws Exception
*/
function custom_warning_handler($errno, $errstr, $errfile, $errline, $errcontext) {
function custom_warning_handler($errno, $errstr, $errfile = null, $errline = null, $errcontext = null) {
if ($errno & error_reporting()) {
throw new Amfphp_Core_Exception("$errstr . \n<br>file: $errfile \n<br>line: $errline \n<br>context: " . print_r($errcontext, true), $errno);
}
Expand Down
2 changes: 2 additions & 0 deletions Amfphp/Plugins/AmfphpFlexMessaging/AcknowledgeMessage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ class AmfphpFlexMessaging_AcknowledgeMessage {
*/
public $headers;

public $_explicitType;

/**
* constructor
* @param string $correlationId
Expand Down
2 changes: 2 additions & 0 deletions Amfphp/Plugins/AmfphpFlexMessaging/ErrorMessage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ class AmfphpFlexMessaging_ErrorMessage {
*/
public $rootCause;

public $_explicitType;

/**
* constructor
* @param type $correlationId
Expand Down
2 changes: 1 addition & 1 deletion Amfphp/Plugins/AmfphpGet/AmfphpGet.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function __construct(array $config = null) {
* @return this or null
*/
public function filterHandler($handler, $contentType){
if(strpos($contentType, self::CONTENT_TYPE) !== false){
if(!is_null($contentType) && strpos($contentType, self::CONTENT_TYPE) !== false){
return $this;
}
}
Expand Down
2 changes: 1 addition & 1 deletion Amfphp/Plugins/AmfphpJson/AmfphpJson.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public function __construct(array $config = null) {
* @return this or null
*/
public function filterHandler($handler, $contentType) {
if (strpos($contentType, self::JSON_CONTENT_TYPE) !== false) {
if (!is_null($contentType) && strpos($contentType, self::JSON_CONTENT_TYPE) !== false) {
return $this;
}
}
Expand Down
2 changes: 1 addition & 1 deletion Amfphp/Plugins/AmfphpMonitor/AmfphpMonitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ public function filterDeserializedResponse($deserializedResponse) {
* @param mixed $rawData
*/
public function filterSerializedResponse($rawData) {
if(substr($this->uri, 0, 6) == 'Amfphp'){
if(!is_null($this->uri) && substr($this->uri, 0, 6) == 'Amfphp'){
return;
}

Expand Down
1 change: 1 addition & 0 deletions Examples/Php/Vo/UserVo1.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
* @package Amfphp_Examples_ExampleService
* @author Ariel Sommeria-klein
*/
#[AllowDynamicProperties]
class UserVo1 {
/**
*name
Expand Down