Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Python 3.12.3 constrained #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for Python 3.12.3 constrained #18

wants to merge 1 commit into from

Conversation

Praveenraj-K
Copy link
Contributor

Fixed

  • Encountered a compatibility issue with the datetime module while installing s3cmd, indicating the use of an older version.
  • Decided to install s3cmd from the source to ensure the latest version is used.
  • The source installation pulls the latest fixes from GitHub, which may not be available in package manager releases.
  • Tested the installation locally in a Docker container, and it worked without issues.

@Praveenraj-K Praveenraj-K requested a review from a team February 8, 2025 08:10
forevermatt
forevermatt reviewed Feb 10, 2025
View reviewed changes
Dockerfile
Comment on lines +18 to +23
RUN wget https://github.com/s3tools/s3cmd/archive/refs/tags/v2.4.0.tar.gz \
&& tar xzf v2.4.0.tar.gz \
&& cd s3cmd-2.4.0 \
&& python setup.py install \
&& cd .. \
&& rm -rf s3cmd-2.4.0 v2.4.0.tar.gz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a benefit to installing from source, rather than using their pre-built binary in that GitHub release?

https://github.com/s3tools/s3cmd/releases/download/v2.4.0/s3cmd-2.4.0.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt left review comments

@briskt briskt briskt approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Praveenraj-K @briskt @forevermatt