Conversation
Raised by Jason on #1135, after the merge. MoStemMsa.IsFieldRelevant withholds FromPartsOfSpeech ("Attaches to Categories") unless the owning entry has a proclitic or enclitic, and Morphology.fwlayout:39 declares that part visibility="always" -- so before the relevance gate the row composed on every stem MSA, and now it disappears for every entry without a clitic. That is the gate's most visible consequence and nothing pinned it. The test is Jason's, run and confirmed to bite: suppressing the gate fails its negative half with "Expected: False, But was: True", while the positive control -- add a proclitic allomorph, change nothing else -- keeps passing. Also corrects two comments that claimed more than the code does. The composer implements the SECOND of SliceFilter.IncludeSlice's two gates; the first looks the slice id up in the tool's filter list, and the id never reaches the composer, so that half is LT-22802. The fixture summary said it covered the remainder of the overrides, which was untrue while this test was missing, and still excludes the InflectionClass limb that withholds the row from a compound rule's left/right MSA. xWorksTests filter Avalonia 1642 passed, 0 failed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
==========================================
- Coverage 38.89% 38.88% -0.01%
==========================================
Files 1518 1518
Lines 352262 352262
Branches 40597 40597
==========================================
- Hits 137005 136984 -21
- Misses 185976 185997 +21
Partials 29281 29281
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the one composer test that was missing for the field-relevance gate, raised by
@jasonleenaylor after #1135 merged.
MoStemMsa.IsFieldRelevantwithholds Attaches to Categories (FromPartsOfSpeech)unless the owning entry has a proclitic or enclitic allomorph.
Morphology.fwlayoutdeclares that part
visibility="always", so before the relevance gate landed the rowcomposed on every stem MSA. That makes it the gate's most visible consequence, and it
was the only one of its rules with no test.
The test bites
It is Jason's test, run and falsified rather than taken on trust:
Expected: False, But was: TrueThe positive control adds a proclitic allomorph and changes nothing else, so the same
row on the same object is shown to appear as well as to vanish.
Also
Two comments claimed more than the code does, and are corrected:
IsIrrelevantForObjectdescribed itself as the whole ofSliceFilter.IncludeSlice.It implements one of that method's two gates.
IsFieldRelevantoverrides,which was untrue while this test was missing. It now names the one limb still
uncovered: the
InflectionClasscase that withholds the row from a compound rule'sleft or right MSA.
Verification
No behaviour change -- one test and two comments.
-TestFilter Avalonia: 1643 passed, 2 skipped, 0 failedbuild.ps1 -CommentHygiene -TokenHygienecleanThe
LexiconFirstSliceEditContextEdgeCaseTeststeardown error in that run ispre-existing and unrelated:
Validate_WhitespaceOnlyLexeme_IsAnErrorstages an edit andnever commits or cancels it, so the unit-of-work write lock is still held when the cache
is disposed.
git blameputs it in LT-22625 (#964). Nothing here touches that file.🤖 Generated with Claude Code
This change is