-
-
Couldn't load subscription status.
- Fork 10
[frontend] Migrate 5 components from deprecations #3854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3854 +/- ##
==========================================
- Coverage 74.19% 74.17% -0.02%
==========================================
Files 288 288
Lines 10617 10611 -6
Branches 1323 1323
==========================================
- Hits 7877 7871 -6
Misses 2353 2353
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor with the ids, makes the testing clean clear and stable.
Reviewed 1 of 5 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Part of #3787
Notes for review:
<Grid>with<Grid2>,<Stack>,<Box>,<div>, or nothing, as fit the design need.<Stack direction="row">can be used in place of<Grid2>when we don't want the items in the row to wrap to a second row in a narrow windowmaster(on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited componentsThe only component with a visual difference is the
AnalyticsConsent, with slightly less padding (for the sake of narrow windows)Before'n'after screenshots with
AppBarandAnalyticsConsent400px wide


900px wide


This change is