Skip to content

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 9, 2025

Part of #3787

Notes for review:

  • In most places, replaced <Grid> with <Grid2>, <Stack>, <Box>, <div>, or nothing, as fit the design need.
  • <Stack direction="row"> can be used in place of <Grid2> when we don't want the items in the row to wrap to a second row in a narrow window
  • Do a side-by-side visual comparison between this and master (on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited components
  • Try each edited component with various window widths > 400px (we don't support narrower than that)
  • To test UploadImage and ViewImageDialog (respectively):
    • go to project settings > "Users" tab > "Manage speakers", add a speaker, click the + preceding the speaker name, select "Upload image consent"
    • click the "Browse" button and select any image file from your computer, click the "Save" button, click the image icon preceding the speaker name (where the + used to be)
  • Test SiteSettings by logging in with a site admin (https://github.com/sillsdev/TheCombine?tab=readme-ov-file#grant-admin-rights), then click your avatar to open the UserMenu and the top option will be "Site Settings"
  • Test with a few different UI languages

Screenshot pairs below are before and after


Project Settings > Languages > Analysis > text wrapping

300px
Screenshot 2025-06-19 095510Screenshot 2025-06-19 095523


Project Settings > Semantic Domains > Custom Semantic Domains > look at spacing around icons

900px
Screenshot 2025-06-19 094140
Screenshot 2025-06-19 094300

350px
Screenshot 2025-06-19 094341Screenshot 2025-06-19 094355


Site Settings > Users > delete user dialog

Screenshot 2025-06-19 092444
Screenshot 2025-06-19 092502


Site Settings > Banners

800px
Screenshot 2025-06-19 092551
Screenshot 2025-06-19 092600

400px
Screenshot 2025-06-19 092648Screenshot 2025-06-19 092655


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jun 9, 2025
@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. project labels Jun 9, 2025
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

❌ Patch coverage is 53.06122% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.13%. Comparing base (1fe94f6) to head (ba2c907).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rc/components/ProjectSettings/ProjectLanguages.tsx 65.38% 8 Missing and 1 partial ⚠️
...s/ProjectSettings/ProjectSchedule/DateSelector.tsx 0.00% 4 Missing ⚠️
...ts/SiteSettings/UserManagement/ConfirmDeletion.tsx 0.00% 4 Missing ⚠️
src/components/ProjectSettings/ProjectName.tsx 50.00% 2 Missing ⚠️
...nents/ProjectSettings/ProjectProtectedOverride.tsx 0.00% 2 Missing ⚠️
src/components/Dialogs/UploadImage.tsx 0.00% 1 Missing ⚠️
...ojectSettings/ProjectSchedule/DateScheduleEdit.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3863   +/-   ##
=======================================
  Coverage   74.13%   74.13%           
=======================================
  Files         288      288           
  Lines       10606    10614    +8     
  Branches     1323     1326    +3     
=======================================
+ Hits         7863     7869    +6     
- Misses       2358     2359    +1     
- Partials      385      386    +1     
Flag Coverage Δ
backend 85.41% <ø> (ø)
frontend 65.58% <53.06%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 23 files at r1, 5 of 11 files at r2, 7 of 8 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 6479723 into master Aug 7, 2025
17 of 18 checks passed
@imnasnainaec imnasnainaec deleted the grid2d-settings branch August 7, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants