-
-
Notifications
You must be signed in to change notification settings - Fork 10
[ProjectSettings, SiteSettings] Migrate from deprecated Grid #3863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3863 +/- ##
=======================================
Coverage 74.13% 74.13%
=======================================
Files 288 288
Lines 10606 10614 +8
Branches 1323 1326 +3
=======================================
+ Hits 7863 7869 +6
- Misses 2358 2359 +1
- Partials 385 386 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 23 files at r1, 5 of 11 files at r2, 7 of 8 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Part of #3787
Notes for review:
<Grid>
with<Grid2>
,<Stack>
,<Box>
,<div>
, or nothing, as fit the design need.<Stack direction="row">
can be used in place of<Grid2>
when we don't want the items in the row to wrap to a second row in a narrow windowmaster
(on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited componentsUploadImage
andViewImageDialog
(respectively):SiteSettings
by logging in with a site admin (https://github.com/sillsdev/TheCombine?tab=readme-ov-file#grant-admin-rights), then click your avatar to open theUserMenu
and the top option will be "Site Settings"Screenshot pairs below are before and after
Project Settings > Languages > Analysis > text wrapping
300px


Project Settings > Semantic Domains > Custom Semantic Domains > look at spacing around icons
900px


350px


Site Settings > Users > delete user dialog
Site Settings > Banners
800px


400px


This change is