Skip to content

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 16, 2025

Part of #3787

Notes for review:

  • In most places, replaced <Grid> with <Grid2>, <div>, or nothing, as fit the design need.

Notes for testing:

  • Do a side-by-side visual comparison between this and master (on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited components
  • Try each edited component with various window widths > 350px (we don't support narrower than that)
  • Test with a few different UI languages

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jun 16, 2025
@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. component: DataEntry labels Jun 16, 2025
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.85%. Comparing base (2d0319d) to head (a54107a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...onents/DataEntry/DataEntryTable/NewEntry/index.tsx 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3880      +/-   ##
==========================================
- Coverage   73.86%   73.85%   -0.01%     
==========================================
  Files         289      289              
  Lines       10569    10565       -4     
  Branches     1326     1326              
==========================================
- Hits         7807     7803       -4     
  Misses       2376     2376              
  Partials      386      386              
Flag Coverage Δ
backend 85.41% <ø> (ø)
frontend 65.20% <62.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec

This comment was marked as outdated.

@imnasnainaec imnasnainaec added the wip Work In Progress label Jun 19, 2025
@github-actions github-actions bot added the test label Aug 15, 2025
@imnasnainaec imnasnainaec marked this pull request as ready for review August 15, 2025 14:49
@imnasnainaec imnasnainaec removed the wip Work In Progress label Aug 15, 2025
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 19, 2025 19:22
@imnasnainaec imnasnainaec merged commit 72d059f into master Aug 19, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the grid2f-dataentry branch August 19, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DataEntry frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants