-
-
Notifications
You must be signed in to change notification settings - Fork 10
[DataEntry] Migrate from deprecated Grid #3880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3880 +/- ##
==========================================
- Coverage 73.86% 73.85% -0.01%
==========================================
Files 289 289
Lines 10569 10565 -4
Branches 1326 1326
==========================================
- Hits 7807 7803 -4
Misses 2376 2376
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Part of #3787
Notes for review:
<Grid>
with<Grid2>
,<div>
, or nothing, as fit the design need.Notes for testing:
master
(on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited componentsThis change is