Skip to content

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 12, 2025

Part of #3879


This change is Reviewable

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.07%. Comparing base (efbfe3c) to head (15b2344).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...geDuplicates/MergeDupsStep/MergeDragDrop/index.tsx 50.00% 2 Missing ⚠️
...MergeDuplicates/MergeDupsStep/SaveDeferButtons.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3930      +/-   ##
==========================================
+ Coverage   74.03%   74.07%   +0.03%     
==========================================
  Files         288      288              
  Lines       10624    10624              
  Branches     1329     1329              
==========================================
+ Hits         7866     7870       +4     
+ Misses       2371     2368       -3     
+ Partials      387      386       -1     
Flag Coverage Δ
backend 85.52% <ø> (+0.08%) ⬆️
frontend 65.38% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 13, 2025 18:27
@imnasnainaec imnasnainaec merged commit 26fe97f into master Aug 13, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the grid2h-merge branch August 13, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants