Conversation
…Extensions.InitializeWithAvailableUILocales
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mark-sil and @tombogle).
SIL.Windows.Forms/Extensions/ToolStripExtensions.cs line 56 at r1 (raw file):
/// strings. If this menu is a <see cref="ToolStripDropDownButton"/>, it also has its text /// set to the name of the selected language. /// Finally, if a primary <see cref="ILocalizationManager"/> is provided, a separate "More"
devin review says
Stale documentation comment references non-existent 'More' menu item
The documentation at ToolStripExtensions.cs:56-57 still states: "Finally, if a primary ILocalizationManager is provided, a separate 'More' item is added at the bottom of the menu." However, there is no ILocalizationManager parameter in the method signature, and no code in the method body adds a 'More' menu item. This is a pre-existing issue (present before this PR) that should be cleaned up. The CHANGELOG at line 52 indicates this functionality was removed in a previous release, but the summary documentation was never updated.
Merge if you want, with or without changing.
CHANGELOG.md line 20 at r1 (raw file):
### Changed - [SIL.Windows.Forms] BREAKING CHANGE: Removed optional moreSelected parameter from ToolStripExtensions.InitializeWithAvailableUILocales method. This parameter was no longer being used. Clients that want to have a More meun item that performs a custom action will now need to add it themselves.
meun -> menu
(typo)
cb6a476 to
a7928c0
Compare
tombogle
left a comment
There was a problem hiding this comment.
@tombogle made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @andrew-polk and @mark-sil).
CHANGELOG.md line 20 at r1 (raw file):
Previously, andrew-polk wrote…
meun -> menu
(typo)
Done.
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mark-sil).
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tombogle).
This change is