Skip to content

+semver:major: Removed moreSelected param from ToolStripExtensions.InitializeWithAvailableUILocales#1489

Merged
tombogle merged 2 commits intomasterfrom
remove-more-selected-param
Feb 4, 2026
Merged

+semver:major: Removed moreSelected param from ToolStripExtensions.InitializeWithAvailableUILocales#1489
tombogle merged 2 commits intomasterfrom
remove-more-selected-param

Conversation

@tombogle
Copy link
Contributor

@tombogle tombogle commented Feb 2, 2026

This change is Reviewable

@tombogle tombogle self-assigned this Feb 2, 2026
@tombogle tombogle requested a review from mark-sil February 2, 2026 22:52
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Palaso Tests

     4 files  ±0       4 suites  ±0   10m 54s ⏱️ +52s
 5 092 tests ±0   4 858 ✅ ±0  234 💤 ±0  0 ❌ ±0 
16 591 runs  ±0  15 870 ✅ ±0  721 💤 ±0  0 ❌ ±0 

Results for commit a7928c0. ± Comparison against base commit a76d787.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mark-sil and @tombogle).


SIL.Windows.Forms/Extensions/ToolStripExtensions.cs line 56 at r1 (raw file):

		/// strings. If this menu is a <see cref="ToolStripDropDownButton"/>, it also has its text
		/// set to the name of the selected language.
		/// Finally, if a primary <see cref="ILocalizationManager"/> is provided, a separate "More"

devin review says


Stale documentation comment references non-existent 'More' menu item

The documentation at ToolStripExtensions.cs:56-57 still states: "Finally, if a primary ILocalizationManager is provided, a separate 'More' item is added at the bottom of the menu." However, there is no ILocalizationManager parameter in the method signature, and no code in the method body adds a 'More' menu item. This is a pre-existing issue (present before this PR) that should be cleaned up. The CHANGELOG at line 52 indicates this functionality was removed in a previous release, but the summary documentation was never updated.


Merge if you want, with or without changing.


CHANGELOG.md line 20 at r1 (raw file):

### Changed
- [SIL.Windows.Forms] BREAKING CHANGE: Removed optional moreSelected parameter from ToolStripExtensions.InitializeWithAvailableUILocales method. This parameter was no longer being used. Clients that want to have a More meun item that performs a custom action will now need to add it themselves.

meun -> menu
(typo)

@tombogle tombogle force-pushed the remove-more-selected-param branch from cb6a476 to a7928c0 Compare February 3, 2026 13:31
Copy link
Contributor Author

@tombogle tombogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombogle made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @andrew-polk and @mark-sil).


CHANGELOG.md line 20 at r1 (raw file):

Previously, andrew-polk wrote…

meun -> menu
(typo)

Done.

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mark-sil).

Copy link
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tombogle).

@tombogle tombogle merged commit 0a19579 into master Feb 4, 2026
11 checks passed
@tombogle tombogle deleted the remove-more-selected-param branch February 4, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants