Skip to content

+semver:major Upgraded to latest *beta* version of L10NSharp DLLs#1490

Merged
tombogle merged 3 commits intomasterfrom
upgrade-l10nSharp
Feb 17, 2026
Merged

+semver:major Upgraded to latest *beta* version of L10NSharp DLLs#1490
tombogle merged 3 commits intomasterfrom
upgrade-l10nSharp

Conversation

@tombogle
Copy link
Contributor

@tombogle tombogle commented Feb 16, 2026

BREAKING CHANGE in LocalizationIncompleteDlg
IMPORTANT: Do not release this version of libpalaso DLLs until L10nSharp 10.0 has been released and we have upgraded to reference it.


This change is Reviewable

BREAKING CHANGE in LocalizationIncompleteDlg
IMPORTANT: Do not release this version of libpalaso DLLs until L10nSharp 10.0 has been released and we have upgraded to reference it.
@tombogle tombogle self-assigned this Feb 16, 2026
@tombogle tombogle added api change dependencies Pull requests that update a dependency file labels Feb 16, 2026
@github-actions
Copy link

github-actions bot commented Feb 16, 2026

Palaso Tests

     4 files  ±0       4 suites  ±0   10m 2s ⏱️ +10s
 5 092 tests ±0   4 859 ✅ ±0  233 💤 ±0  0 ❌ ±0 
16 591 runs  ±0  15 871 ✅ ±0  720 💤 ±0  0 ❌ ±0 

Results for commit 408987d. ± Comparison against base commit 0a19579.

♻️ This comment has been updated with latest results.

…ionIncompleteViewModel's constructor rather than making EmailAddressForLocalizationRequests virtual

This avoids possibly requiring an override of the class merely to have this property return a useful value.
Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk reviewed 10 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aror92, @mark-sil, and @tombogle).


CHANGELOG.md line 51 at r1 (raw file):
Maybe be a little more explicit about the nature of the break?
Something like,

BREAKING CHANGE: LocalizationIncompleteDlg's EmailAddressForLocalizationRequests is no longer autopopulated from LocalizationManager. As a replacement, added optional emailAddressForLocalizationRequests to LocalizationIncompleteDlg's constructor. If not supplied, the "More information" controls will be hidden.


SIL.Windows.Forms/LocalizationIncompleteDlg/LocalizationIncompleteViewModel.cs line 62 at r1 (raw file):

			_issueRequestForLocalization = issueRequestForLocalization;
			EmailAddressForLocalizationRequests = emailAddressForLocalizationRequests;
		}

Is it worth changing the test app to pass this?

Better wording in CHANGELOG.
Supplied email addtress parameter to the LocalizationIncompleteViewModel constructor in TestAppForm
@tombogle
Copy link
Contributor Author

image

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk reviewed 3 files and all commit messages, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aror92 and @mark-sil).

@tombogle tombogle merged commit 34a3d78 into master Feb 17, 2026
11 checks passed
@tombogle tombogle deleted the upgrade-l10nSharp branch February 17, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants