+semver:major Upgraded to latest *beta* version of L10NSharp DLLs#1490
+semver:major Upgraded to latest *beta* version of L10NSharp DLLs#1490
Conversation
BREAKING CHANGE in LocalizationIncompleteDlg IMPORTANT: Do not release this version of libpalaso DLLs until L10nSharp 10.0 has been released and we have upgraded to reference it.
…ionIncompleteViewModel's constructor rather than making EmailAddressForLocalizationRequests virtual This avoids possibly requiring an override of the class merely to have this property return a useful value.
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 10 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aror92, @mark-sil, and @tombogle).
CHANGELOG.md line 51 at r1 (raw file):
Maybe be a little more explicit about the nature of the break?
Something like,
BREAKING CHANGE: LocalizationIncompleteDlg's EmailAddressForLocalizationRequests is no longer autopopulated from LocalizationManager. As a replacement, added optional emailAddressForLocalizationRequests to LocalizationIncompleteDlg's constructor. If not supplied, the "More information" controls will be hidden.
SIL.Windows.Forms/LocalizationIncompleteDlg/LocalizationIncompleteViewModel.cs line 62 at r1 (raw file):
_issueRequestForLocalization = issueRequestForLocalization; EmailAddressForLocalizationRequests = emailAddressForLocalizationRequests; }
Is it worth changing the test app to pass this?
Better wording in CHANGELOG. Supplied email addtress parameter to the LocalizationIncompleteViewModel constructor in TestAppForm
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 3 files and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aror92 and @mark-sil).

BREAKING CHANGE in LocalizationIncompleteDlg
IMPORTANT: Do not release this version of libpalaso DLLs until L10nSharp 10.0 has been released and we have upgraded to reference it.
This change is