Skip to content

Clean projects #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Clean projects #731

wants to merge 7 commits into from

Conversation

davidbaines
Copy link
Collaborator

@davidbaines davidbaines commented May 27, 2025

Updates to common.clean_projects to use multi threading and improvements to the logging.


This change is Reviewable

Copy link
Collaborator

@benjaminking benjaminking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @mshannon-sil)


silnlp/common/clean_projects.py line 412 at r1 (raw file):

            all_folders.append(item)

    test = True

Was this supposed to be included? Or was it left over from debugging/testing?

@davidbaines
Copy link
Collaborator Author

I've removed the test code and also put "TermRenderings.xml" in lower case.

Copy link
Collaborator

@benjaminking benjaminking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @davidbaines and @mshannon-sil)


silnlp/common/clean_projects.py line 412 at r1 (raw file):

Previously, benjaminking (Ben King) wrote…

Was this supposed to be included? Or was it left over from debugging/testing?

I believe the "test" variable should also be removed since it's no longer used.

@davidbaines
Copy link
Collaborator Author

Thanks Ben good catch.

Copy link
Collaborator

@benjaminking benjaminking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @mshannon-sil)


silnlp/common/clean_projects.py line 344 at r3 (raw file):

    # --- Configure Logging ---
    #log_formatter = logging.Formatter("%(asctime)s - %(levelname)s - %(message)s")
    log_formatter = logging.Formatter("2025-05-29 14:30:00,000 - %(levelname)s - %(message)s")

One last thing: the hard-coded date in the format string here will cause all of the log messages to print "2025-05-29"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants