Skip to content

Conversation

@davidbaines
Copy link
Collaborator

@davidbaines davidbaines commented Dec 5, 2025

This update to combine_scores is designed to pull all the different Scores files into one Excel table. Where there are two or more scores files with a different set or order of columns they are combined into one dataframe so that the output is not on separate tabs in Excel.

This change should not affect any file other than combine_scores.py


This change is Reviewable

Copy link
Collaborator

@benjaminking benjaminking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@benjaminking reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @davidbaines)


silnlp/common/combine_scores.py line 117 at r1 (raw file):

def clean_dataframe(df):
    cleaned_df = df.copy()
    cleaned_df = cleaned_df[~((cleaned_df['trg_iso'] == 'ALL') & (cleaned_df['chrF3++'].isna() | (cleaned_df['chrF3++'] == '')))]

It could be worth adding a comment to this line. It's not super obvious from reading it what the line is doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants