Add e2e tests #3137

Nateowami · 2025-04-01T20:47:01Z

This change is

Nateowami · 2025-05-29T19:28:33Z

src/SIL.XForge.Scripture/ClientApp/e2e/e2e-utils.ts

+  if (projectName == null) throw new Error('Project name not found');
+  await page.getByRole('textbox', { name: 'Project Name' }).click();
+  await page.getByRole('textbox', { name: 'Project Name' }).click();
+  if (projectName == null) throw new Error('Project name not found');


To fix the problem, we need to remove the redundant check projectName == null on line 180. Since the projectName variable can only be undefined or a string, we should replace the check with projectName === undefined. This will ensure that the code correctly handles the case where projectName is not found without introducing unnecessary defensive code.

No idea why it's saying this.

src/SIL.XForge.Scripture/ClientApp/e2e/workflows/community-checking.ts

codecov · 2025-04-01T20:57:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.98%. Comparing base (216129d) to head (9b207ce).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3137   +/-   ##
=======================================
  Coverage   81.98%   81.98%           
=======================================
  Files         604      604           
  Lines       34673    34673           
  Branches     5600     5622   +22     
=======================================
  Hits        28428    28428           
+ Misses       5417     5405   -12     
- Partials      828      840   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Also removed executable flag from smoke-tests.mts

Nateowami · 2025-05-29T17:14:48Z

@pmachapman I've updated the files names to be more consistent.

Nateowami

Reviewable status: 33 of 38 files reviewed, 1 unresolved discussion (waiting on @marksvc and @pmachapman)

src/SIL.XForge.Scripture/ClientApp/e2e/e2e-utils.ts line 74 at r3 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

Is this an app bug, a test bug, or a test runner bug?

I don't remember. I do remember having a lot of issues with race conditions on the my projects page, and figuring out how to properly handle them.

That said, if (a) return true; else return false; is hideous so I've fixed it.

Nateowami · 2025-05-29T19:28:33Z

src/SIL.XForge.Scripture/ClientApp/e2e/e2e-utils.ts

+  if (projectName == null) throw new Error('Project name not found');
+  await page.getByRole('textbox', { name: 'Project Name' }).click();
+  await page.getByRole('textbox', { name: 'Project Name' }).click();
+  if (projectName == null) throw new Error('Project name not found');


No idea why it's saying this.

Nateowami force-pushed the feature/e2e-tests branch from c44abb7 to c6ce63d Compare April 1, 2025 20:48

Nateowami had a problem deploying to e2e_tests April 1, 2025 20:48 — with GitHub Actions Failure

github-advanced-security bot found potential problems Apr 1, 2025

View reviewed changes

Nateowami force-pushed the feature/e2e-tests branch from c6ce63d to 511f1c6 Compare April 1, 2025 20:57

Nateowami had a problem deploying to e2e_tests April 1, 2025 20:57 — with GitHub Actions Failure

Nateowami force-pushed the feature/e2e-tests branch from 511f1c6 to 240ee13 Compare April 1, 2025 21:10

Nateowami had a problem deploying to e2e_tests April 1, 2025 21:12 — with GitHub Actions Failure

Nateowami force-pushed the feature/e2e-tests branch from 240ee13 to da62195 Compare April 1, 2025 21:23

Nateowami temporarily deployed to e2e_tests April 1, 2025 21:23 — with GitHub Actions Inactive

Nateowami force-pushed the feature/e2e-tests branch from da62195 to 70c712a Compare April 1, 2025 21:28

Nateowami temporarily deployed to e2e_tests April 1, 2025 21:28 — with GitHub Actions Inactive

Nateowami force-pushed the feature/e2e-tests branch from 70c712a to 05107a7 Compare April 1, 2025 22:00

Nateowami had a problem deploying to e2e_tests April 1, 2025 22:00 — with GitHub Actions Failure

Nateowami force-pushed the feature/e2e-tests branch from 05107a7 to ee77482 Compare April 1, 2025 22:01

Nateowami had a problem deploying to e2e_tests April 1, 2025 22:01 — with GitHub Actions Failure

Nateowami force-pushed the feature/e2e-tests branch from ee77482 to a868388 Compare April 1, 2025 22:03

Nateowami had a problem deploying to e2e_tests April 1, 2025 22:03 — with GitHub Actions Failure

Nateowami force-pushed the feature/e2e-tests branch from a868388 to 8f539c4 Compare April 1, 2025 22:15

Nateowami had a problem deploying to e2e_tests April 1, 2025 22:15 — with GitHub Actions Error

Nateowami force-pushed the feature/e2e-tests branch from 8f539c4 to c7d706b Compare April 3, 2025 15:50

Nateowami had a problem deploying to e2e_tests April 3, 2025 15:50 — with GitHub Actions Failure

marksvc had a problem deploying to e2e_tests April 14, 2025 20:14 — with GitHub Actions Failure

marksvc had a problem deploying to e2e_tests April 14, 2025 20:21 — with GitHub Actions Failure

marksvc had a problem deploying to e2e_tests April 14, 2025 20:26 — with GitHub Actions Failure

marksvc had a problem deploying to e2e_tests April 14, 2025 20:31 — with GitHub Actions Error

marksvc had a problem deploying to e2e_tests April 14, 2025 20:39 — with GitHub Actions Error

marksvc had a problem deploying to e2e_tests April 14, 2025 20:45 — with GitHub Actions Failure

marksvc had a problem deploying to e2e_tests April 14, 2025 20:58 — with GitHub Actions Failure

marksvc had a problem deploying to e2e_tests April 14, 2025 21:18 — with GitHub Actions Failure

marksvc and others added 24 commits May 29, 2025 12:46

improve script

311be95

script: timing. wording

745b218

Specify development invronment when running dotnet in CI

762dad5

Wait for sync to finish after clicking save and sync

9755d4c

Limit retries when running CI

29b22e1

Use underscores instead of colons in e2e test output folders

e2a5837

Format date

290fe94

Add test data license

c1f22d8

Move e2e ignore files to root .gitignore

a69fc3c

Pin setup-deno action to specific commit

6de6c2c

Fix configuring of Serval client secret

482385d

Fixup e2e tests

4efed7f

Characterize tests

5dab65c

Fix tests failing with Windows line endings

327083d

Improve community checking e2e tests

1d66ad0

Re-enable pre-merge workflow

f98160d

Only copy images with changes to the help site

953f11f

Use echo engine

6802459

Add logging to try to figure out why draft doesn't finish

4be54f9

Refresh before running update draft webhook

04074b1

Attempt to get generate draft to pass on first run

c17a63f

Update tests to await startup of application, and run all e2e tests

775d353

Update generate_draft test characterization and remove deno install

4da1b5a

Rename TS files to use consistent naming convention

76152a4

Also removed executable flag from smoke-tests.mts

Nateowami force-pushed the feature/e2e-tests branch from dae6fa5 to 76152a4 Compare May 29, 2025 17:08

Nateowami deployed to e2e_tests May 29, 2025 17:12 — with GitHub Actions Active

Nateowami commented May 29, 2025

View reviewed changes

Update e2e workflow to run on schedule but not PRs

9b207ce

Nateowami force-pushed the feature/e2e-tests branch from 127de15 to 9b207ce Compare May 29, 2025 21:22

@@ -179,3 +179,3 @@
               await page.getByRole('textbox', { name: 'Project Name' }).click();
-              if (projectName == null) throw new Error('Project name not found');
+              if (projectName === undefined) throw new Error('Project name not found');
               await page.getByRole('textbox', { name: 'Project name' }).fill(projectName);

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add e2e tests #3137

Add e2e tests #3137

Uh oh!

Nateowami commented Apr 1, 2025 •

edited by irahopkinson

Loading

Uh oh!

Check notice

Copilot Autofix

Nateowami May 29, 2025

Uh oh!

Uh oh!

codecov bot commented Apr 1, 2025 •

edited

Loading

Uh oh!

Nateowami commented May 29, 2025

Uh oh!

Nateowami left a comment

Uh oh!

Nateowami May 29, 2025

Uh oh!

Uh oh!

Uh oh!

Add e2e tests #3137

Are you sure you want to change the base?

Add e2e tests #3137

Uh oh!

Conversation

Nateowami commented Apr 1, 2025 • edited by irahopkinson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Check notice

Copilot Autofix

Nateowami May 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Nateowami commented May 29, 2025

Uh oh!

Nateowami left a comment

Choose a reason for hiding this comment

Uh oh!

Nateowami May 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Nateowami commented Apr 1, 2025 •

edited by irahopkinson

Loading

codecov bot commented Apr 1, 2025 •

edited

Loading