Skip to content

Replaced broken UserFormsGridFieldFilterHeader with a SearchFilter and the default GridFieldFilterHeader#1443

Open
UndefinedOffset wants to merge 2 commits into
silverstripe:7from
webbuilders-group:feature-replaced-search
Open

Replaced broken UserFormsGridFieldFilterHeader with a SearchFilter and the default GridFieldFilterHeader#1443
UndefinedOffset wants to merge 2 commits into
silverstripe:7from
webbuilders-group:feature-replaced-search

Conversation

@UndefinedOffset

@UndefinedOffset UndefinedOffset commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes the long standing issue #919 where UserFormsGridFieldFilterHeader would never show up by replacing it with a standard GridFieldFilterHeader and a new SearchFilter. UserFormsGridFieldFilterHeader has not been removed to avoid a breaking change but it is deprecated and no longer used by default. Note: Like UserFormsGridFieldFilterHeader this just uses a case insensitive match on the value not a partial match.

Manual testing steps

  1. Create a user form
  2. Create a field with the "Show in summary search" checkbox set
  3. Fill out and submit the form a couple times to seed some submissions
  4. On the submissions tab expand the "Search options" and search by the form field created in 2

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@UndefinedOffset UndefinedOffset changed the title Replaced broken UserFormsGridFieldFilterHeader with a SearchFilter an… Replaced broken UserFormsGridFieldFilterHeader with a SearchFilter and the default GridFieldFilterHeader Jul 3, 2026
@UndefinedOffset
UndefinedOffset force-pushed the feature-replaced-search branch from 07f50d8 to 211b5c3 Compare July 3, 2026 17:41
@UndefinedOffset
UndefinedOffset force-pushed the feature-replaced-search branch from 4831460 to f41ff61 Compare July 7, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant