Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of small fixes #24

Open
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

mikemaccana
Copy link

@mikemaccana mikemaccana commented Jun 4, 2023

Thanks for the demo project Silvestre! Here's a bunch of minor fixes, mainly getting rid of warnings and adding some not-so-obvious things to the documentation:

  • Use current Vite and SvelteKit
  • Use localnet by default in both Anchor and Svelte
  • Use the current username (rather than silvestrevivo) for Solana CLI config
  • Fix button being off to the side when screen is narrow
  • Fix most warnings
    • Fix security warnings in anchor and Svelte app installs
    • Fix Svelte accessibility warnings
    • Fix Svelte language server warning
    • Fix TypeScript deprecation warnings
    • Fix UI using red warning class when wallet is connected
  • Make log message less mysterious and fix Svelte sigil so it runs when the value changes
  • Docs
    • Add instructions to configure a wallet to use localhost
    • Lots of small English fixes
  • Remove Slope, it's now unsupported and hacked
  • Use npm consistently (rather than yarn for the Anchor app and npm for the Svelte app)

Fixes #23

Svelte language server detected a large amount of JS/Svelte files. To enable project-wide JavaScript/TypeScript language features for Svelte files, exclude large folders in the tsconfig.json or jsconfig.json with source files that you do not work on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some instances of localhost may need to be localnet
1 participant