Skip to content

Conversation

@woutdenolf
Copy link
Collaborator

No description provided.

@woutdenolf woutdenolf force-pushed the xrffit_multidetector branch 4 times, most recently from d330dc2 to 7408ccd Compare August 19, 2020 14:45
@woutdenolf woutdenolf changed the title multidetector xrf fits [WIP] multidetector xrf fits Aug 19, 2020
@woutdenolf woutdenolf force-pushed the xrffit_multidetector branch from 7408ccd to 5e0818a Compare January 21, 2021 15:01
@vasole
Copy link
Member

vasole commented Jan 21, 2021

I think it would be much less intrusive to do the following:

  • ClassMcaTheory.py becomes LegacyClassMcaTheory
  • The new ClassMcaTheory imports McaTheory from LegacyClassMcaTheory
  • The new Class (if any) in ClassMcaTheory is named ClassMcaTheory as it is the style followed everywhere else in the project.

@woutdenolf
Copy link
Collaborator Author

ClassMcaTheory.py becomes LegacyClassMcaTheory.py

That's already the case.

The new Class (if any) in ClassMcaTheory is named ClassMcaTheory

Yes that will be the case.

The new ClassMcaTheory imports McaTheory from LegacyClassMcaTheory

That's not going to be possible imo.

@vasole
Copy link
Member

vasole commented Jan 21, 2021

You are correct. At a certain point I put a dummy ClassMcaTheory to follow the convention available everywhere else :(

@vasole
Copy link
Member

vasole commented Jan 21, 2021

We'll have to take care.

There are recipes around showing how to directly use the current McaTheory "public" API (configure, setData, estimate, startfit)

@woutdenolf woutdenolf force-pushed the xrffit_multidetector branch from 049bb26 to 40d1689 Compare January 22, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants