Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProxyGenerator: Update regex pattern to match simple id getters with custom id type #1

Open
wants to merge 54 commits into
base: 3.3.x
Choose a base branch
from

Conversation

simPod
Copy link
Owner

@simPod simPod commented Nov 20, 2021

@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Patch coverage: 96.77% and project coverage change: +0.95 🎉

Comparison is base (6a76bd2) 93.42% compared to head (ad16d6a) 94.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##            3.3.x       #1      +/-   ##
==========================================
+ Coverage   93.42%   94.38%   +0.95%     
==========================================
  Files          10       10              
  Lines         654      712      +58     
==========================================
+ Hits          611      672      +61     
+ Misses         43       40       -3     
Impacted Files Coverage Δ
src/ClassLoader.php 84.00% <ø> (ø)
src/Proxy/AbstractProxyFactory.php 78.68% <ø> (ø)
src/Proxy/Autoloader.php 90.90% <ø> (ø)
src/Proxy/Exception/OutOfBoundsException.php 100.00% <ø> (ø)
src/Proxy/Exception/UnexpectedValueException.php 90.47% <ø> (ø)
src/Proxy/ProxyDefinition.php 100.00% <ø> (ø)
src/Util/ClassUtils.php 100.00% <ø> (ø)
src/Util/Debug.php 89.28% <ø> (ø)
src/Proxy/ProxyGenerator.php 98.47% <96.55%> (ø)
src/Proxy/Exception/InvalidArgumentException.php 90.47% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simPod simPod changed the base branch from 3.2.x to 3.3.x April 22, 2022 17:01
derrabus and others added 26 commits August 7, 2022 20:10
….x_8Xwejl36

Merge release 3.3.1 into 3.4.x
The file was added in b4b6403, without
a CI command to use it.
There should be no IDE-specific ignore rules. People can and should have
global ignore rules for this instead of adding them to each and every
project they touch.
It should have been removed in 4167060.
It does not appear to serve any purpose.
The referenced issue is fixed, but the fix is not released yet. However,
since the "tests" directory is not currently analyzed, the ignore rule
is useless.
Also, the rule about ignoring the vendor directory is useless.
This should make it easier to use a fuzzy matcher.
Co-authored-by: Nicolas Grekas <[email protected]>
@simPod simPod force-pushed the id-pattern branch 3 times, most recently from 3ddda32 to ad16d6a Compare April 13, 2023 20:55
VincentLanglet and others added 14 commits July 29, 2023 18:03
Add phpstan.neon.dist and psalm.xml to .gitattributes
Generate explicit nullable types for proxies
Bumps [doctrine/.github](https://github.com/doctrine/.github) from 1.4.0 to 5.0.1.
- [Release notes](https://github.com/doctrine/.github/releases)
- [Commits](doctrine/.github@1.4.0...5.0.1)

---
updated-dependencies:
- dependency-name: doctrine/.github
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…ons/doctrine/dot-github-5.0.1

Bump doctrine/.github from 1.4.0 to 5.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants