Consider setting `ActionSettings::require_reset` to `true`

[Shatur]

Brought up by #151.

If this value is set to true, layering or swapping context will require the input to become inactive first. I would users opinions on this one.

[olekspickle]

As I stated earlier, looking at all the binding I have I only have requre_reset set to true for like 3/10, but I'm not an experienced gamedev, not sure what default makes more sense.

[Ceedrich]

I think, I would prefer ActionSettings::require_reset to be true by default.
Generally, switching contexts should reset all bindings, as two contexts could be of vastly different nature (i.e gameplay vs. ui). If you have contexts that have similar mechanics (i.e. on foot vs. in car), I think it should be made explicit, which actions should "carry over" into the next context.

Additionally, individual contexts do not "know" which action could potentially be pressed from another context and so the code responsible for the two contexts would live in two different places:

• Where the action with input X is defined in context A
• Where another action with input X is defined in context B that has to handle potential active inputs X from context A

So, in my opinion, setting ActionValue::require_reset to true would be less confusing and more explicit in general.

[Ceedrich]

Should I open a PR to change the default to true? (@Shatur)

[Shatur]

I'd prefer to wait with the decision.

When I play GTA, for example, and enter a car, I can just keep pressing W to make the car move. I don't need to release and press the key again. That's how it works in most games. Requiring reset is only useful for keys that switch context. For all other cases, I think the opposite behavior is expected.