Skip to content

Fix leaking entity ticks#717

Merged
Shatur merged 1 commit into
masterfrom
fix-leaking-ticks
Jun 27, 2026
Merged

Fix leaking entity ticks#717
Shatur merged 1 commit into
masterfrom
fix-leaking-ticks

Conversation

@Shatur

@Shatur Shatur commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@cBournhonesque I found a clean and efficient way. I inspected the ticks logic, we don't need to do a reset on unreplication, the unpause will work correctly.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.97%. Comparing base (22b6b1c) to head (136118c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
+ Coverage   90.96%   90.97%   +0.01%     
==========================================
  Files          73       73              
  Lines        4261     4267       +6     
==========================================
+ Hits         3876     3882       +6     
  Misses        385      385              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cBournhonesque

Copy link
Copy Markdown
Contributor

Good idea!

@Shatur Shatur merged commit 953c31c into master Jun 27, 2026
17 of 18 checks passed
@Shatur Shatur deleted the fix-leaking-ticks branch June 27, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants