-
Notifications
You must be signed in to change notification settings - Fork 425
Modular manager references #3399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Deployed on https://deploy-preview-3399--moor.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
I think we should add tests so that all manager tests are also ran on modular code.
btw, when using the manager it's really helpful to do modular generation because otherwise the generic is private (_$AppDatabase) so I'm pumped about this
This is tricky to pull off without copy-pasting all the tests and keeping them in sync 🤔 After all, we'd have to run both the default and the modular builder on the same database definitions, but they would generate separate and independent manager classes. As a first step, I've added a simple test to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you feel the testing is sufficient.
btw, with the status on this PR #3281
The manager templates used to disable generating a typed reference class when modular code-generation was enabled, instead referring to the general
BaseReferencesclass in the runtime package.This adds support for that feature by resolving the modular-specific issues (like referring to typedefs and classes by their imported name if needed).
This is tested by the modular package which can now use that feature. But @dickermoshe it would be helpful if you could take a quick look to make sure I didn't miss anything.
Closes #3398.