Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and improve #63

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Refactor and improve #63

wants to merge 15 commits into from

Conversation

hsnaydd
Copy link

@hsnaydd hsnaydd commented Nov 15, 2019 •
edited
Loading

Summary

  • Refactor & format code
  • Use through2 instead of unmaintained map-stream
  • Update packages
  • Upgrade node engine to version >=10.0.0
  • Add documentation for strict_variables
  • Collect the options that related with twig.js into twigParameters
  • Fix the problem that some errors are not caught

@emr
Copy link

emr commented Nov 15, 2019

Good job! It also fixes #57

@olets olets mentioned this pull request Mar 18, 2021
Open
alex-lenk
alex-lenk approved these changes Jun 21, 2022
View reviewed changes
Copy link

@alex-lenk alex-lenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

alex-lenk
alex-lenk approved these changes Jun 21, 2022
View reviewed changes
Copy link

@alex-lenk alex-lenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-lenk alex-lenk alex-lenk approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsnaydd @emr @alex-lenk