-
-
Notifications
You must be signed in to change notification settings - Fork 325
fix: handle relative paths for haskell-language-server #1784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Mmh. Still need to figure out why the world doesn’t succeed. |
It’s ready for review. I had forgotten to update the package.yaml file. |
Here's the summary of running
The remaining failing files under hledger-web are due to app/devel.hs becauser we're not including warp and directory packages in the build-dependns section. I'm planning on fixing this in the next PR. |
This is needed for both `cabal build hledger-web` and `haskell-language-server` to succeed. This was already done in the heldger-cli package for example but not in the heldger-web package. In essence, hls and stack/cabal uses different roots when embedding files in template haskell in sub-packages. Reference: haskell/haskell-language-server#481 (comment)
Thanks for this @ibizaman. I wonder how to reproduce, |
AFAICT I'm on the same version as you.
I'm using a custom haskell.nix file to run hls but I don't think (?) it should have an impact. Reproducing for me is just running Log output
|
Strange. With current master, with or without this PR on top of it, I see a similar list of failed files but they are all inconsequential, with only two failed hledger-web files:
Perhaps the problem is the hie.yaml file in your branch; try rebasing on master, where that file has been removed. |
Well well well, that'll teach me for not being on the latest master:
Thanks for putting up with me anyway! |
Alright! If your fix is still useful it'll probably come up again. Thanks for the work. |
This is needed for both
cabal build hledger-web
andhaskell-language-server
to succeed. This was already done in theheldger-cli package for example but not in the heldger-web package. In
essence, hls and stack/cabal uses different roots when embedding files
in template haskell in sub-packages.
Reference: haskell/haskell-language-server#481 (comment)
Example of error: