Skip to content

REFACTOR: don't pass built maps between processes#146

Open
ColmTalbot wants to merge 2 commits intomainfrom
refactor-coadding
Open

REFACTOR: don't pass built maps between processes#146
ColmTalbot wants to merge 2 commits intomainfrom
refactor-coadding

Conversation

@ColmTalbot
Copy link
Collaborator

This PR makes two changes:

  • refactor how the coadding is implemented so that there are two stages (identifying which maps should be coadded using metadata, actually doing the coadding) so that built maps don't need to be passed between processes. This seems to be reducing our memory footprint some.
  • don't pass the maps to the output classes. We discussed this on a previous call and there is only a small loss of information. The lightcurvedb upload is now missing the time, I assume we want to preserve that, but I'm not immediately sure how to pass it.

@ColmTalbot ColmTalbot requested review from JBorrow and axf295 February 25, 2026 14:48
Copy link
Member

@JBorrow JBorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me.

Copy link
Collaborator

@axf295 axf295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a config for the coadding so that coadding can be turned on or off?

@axf295
Copy link
Collaborator

axf295 commented Mar 6, 2026

seems like the lightcurvedb should expect the source observation time to come from the measured source object, not require map_time @JBorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants