Fixes in 'Refactoring' branch

DependencyInjection/SimpleThingsTransactionalExtension.php

@@ -15,6 +15,7 @@
 namespace SimpleThings\TransactionalBundle\DependencyInjection;
 
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 use Symfony\Component\Config\FileLocator;

Doctrine/ObjectTransactionStatus.php

@@ -72,7 +72,7 @@ public function setRollBackOnly()
      */
     public function isCompleted()
     {
-        return $this->isCompleted;
+        return $this->completed;
     }
 
     /**

Doctrine/OrmTransactionStatus.php

@@ -70,7 +70,7 @@ public function setRollBackOnly()
      */
     public function isCompleted()
     {
-        return $this->isCompleted;
+        return $this->completed;
     }
 
     /**
@@ -110,8 +110,8 @@ public function commit()
 
         if ( ! $this->isRollBackOnly() && $this->manager->getConnection()->getTransactionNestingLevel() == 1) {
             $this->manager->flush();
+            $this->manager->getConnection()->commit();
         }
-        $this->manager->commit();
 
         if ($this->manager->getConnection()->getTransactionNestingLevel() == 0) {
             $this->completed = true;

Resources/config/services.xml

@@ -35,7 +35,12 @@
             <argument type="collection" />
         </service>
 
+        <service id="simple_things_transactional.form_validator" class="SimpleThings\TransactionalBundle\Transactions\Form\RollbackInvalidFormValidator" public="false">
+            <argument type="service" id="service_container" />
+        </service>
+
         <service id="simple_things_transactional.form_extension" class="SimpleThings\TransactionalBundle\Transactions\Form\RollbackInvalidFormExtension">
+            <argument type="service" id="simple_things_transactional.form_validator" />
             <tag name="form.type_extension" alias="form" />
         </service>
     </services>

SimpleThingsTransactionalBundle.php

@@ -16,14 +16,14 @@
 
 use Symfony\Component\HttpKernel\Bundle\Bundle;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
-use SimpleThings\TransactionalBundle\DependencyInjection\CompilerPass\DetectConnectionsPass;
+use SimpleThings\TransactionalBundle\DependencyInjection\CompilerPass\DetectConnectionPass;
 
 class SimpleThingsTransactionalBundle extends Bundle
 {
     public function build(ContainerBuilder $container)
     {
         parent::build($container);
 
-        $container->addCompilerPass(new DetectConnectionsPass());
+        $container->addCompilerPass(new DetectConnectionPass());
     }
 }

Transactions/Form/RollbackInvalidFormExtension.php

@@ -15,13 +15,19 @@
 
 use Symfony\Component\Form\AbstractTypeExtension;
 use Symfony\Component\Form\FormBuilder;
-use Symfony\Component\Form\AbstractExtension;
 
-class RollbackInvalidFormExtension extends AbstractExtension
+class RollbackInvalidFormExtension extends AbstractTypeExtension
 {
+    private $validator;
+
+    public function __construct(RollbackInvalidFormValidator $rollbackValidator)
+    {
+        $this->validator = $rollbackValidator;
+    }
+
     public function buildForm(FormBuilder $builder, array $options)
     {
-        $builder->addValidator(new RollbackInvalidFormValidator());
+        $builder->addValidator($this->validator);
     }
 
     public function getExtendedType()

Transactions/Form/RollbackInvalidFormValidator.php

@@ -11,10 +11,10 @@
  * to kontakt@beberlei.de so I can send you a copy immediately.
  */
 
-namespace SimpleThingsTransactionalBundle\Transactions\Form;
+namespace SimpleThings\TransactionalBundle\Transactions\Form;
 
 use Symfony\Component\Form\FormValidatorInterface;
-use Symfony\Component\Form\Form;
+use Symfony\Component\Form\FormInterface;
 
 /**
  * "Missusing" the FormValidator to set transactions to rollback only when the validation failed.
@@ -39,7 +39,7 @@ public function validate(FormInterface $form)
         }
 
         $request = $this->container->get('request');
-        if ( ! $form->isValid( && $request->attributes->has('_transaction') ) {
+        if ( ! $form->isValid() && $request->attributes->has('_transaction') ) {
             $request->attributes->get('_transaction')->setRollBackOnly(true);
         }
     }

Transactions/Http/HttpTransactionsListener.php

@@ -19,7 +19,7 @@
 use Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent;
 use Symfony\Component\HttpKernel\HttpKernelInterface;
 use Symfony\Component\HttpKernel\Log\LoggerInterface;
-use Symfony\Component\HttpFoundation\Exceptions\NotFoundHttpException;
+use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use SimpleThings\TransactionalBundle\Transactions\TransactionsRegistry;
 
 /**