Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to angular 19.1 and add eslint #17

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

feat: upgrade to angular 19.1 and add eslint #17

wants to merge 21 commits into from

Conversation

the-ult
Copy link

@the-ult the-ult commented Jan 13, 2025 •
edited
Loading

Summary

  • upgrade to Angular 19
  • upgrade storybook
  • update dependencies
  • add and apply prettier
  • add and apply ESLint
  • remove karma

TODO:

  • fix storybook tests (seem to be broken in master as well)
  • Add extra tests?

N.B.

  • This does not (yet) apply the signal API schematics etc. I think that should be a seperate PR

The Ult added 16 commits January 13, 2025 19:51
build(deps): update to angular 19
68e0de3
build(storybook): update storybook to 8.4.7
6152c61
build(deps): upgrade vestjs
29bf3e0
build(deps): update dependencies
28163ba
build(deps): remove karma
e7a0f2c 
Since it is not used
build(deps): update Jest setup and TypeScript configuration
adea8a5
build(deps): upgrade playwright to version 1.49.1
58bd9db
build(deps): upgrade husky to version 9.1.7
035988d
build(deps): add Prettier and organize imports plugin
f21c75a 
Prettier was configured, but not installed.
Added organize-imports plugin for consistent imports
- https://www.npmjs.com/package/prettier-plugin-organize-imports
build(deps): update peer dependencies for Angular and RxJS
ef71e35
fix(lint): add eslint and apply fixes
3dd8e7b
fix(examples): replace app-root with sc-root in index.html
3280f49
fix(forms): enhance error handling and retry logic in form directives…
c24ca54 
… and components
build(deps): add eslint-plugin-unicorn and apply auto fixes
87aa580
build(scripts): update start script and reorganize and rename npm scr…
4823aba 
…ipts for clarity
fix(directives): implement AfterViewInit lifecycle hook in FormDirective
0b81480 
Fixes ValidationConfig issue simplifiedcourses#14
See: simplifiedcourses#16
@the-ult the-ult changed the title feat: upgrade to angular 19 and add eslint WIP: feat: upgrade to angular 19 and add eslint Jan 13, 2025
@the-ult the-ult marked this pull request as draft January 13, 2025 21:46
@the-ult the-ult changed the title WIP: feat: upgrade to angular 19 and add eslint feat: upgrade to angular 19 and add eslint Jan 13, 2025
@the-ult the-ult changed the title feat: upgrade to angular 19 and add eslint feat: upgrade to angular 19.1 and add eslint Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@the-ult