Skip to content

fix: return retry policy fields from subscription Get/Search#227

Merged
hamzahalq merged 1 commit into
releases/r8.0from
hamza/fix/subscription-retry-policy-read
Jul 22, 2026
Merged

fix: return retry policy fields from subscription Get/Search#227
hamzahalq merged 1 commit into
releases/r8.0from
hamza/fix/subscription-retry-policy-read

Conversation

@hamzahalq

Copy link
Copy Markdown
Contributor

Get.cs and Search.cs never mapped RetryPolicyId/CustomRetryPolicy onto the response, so a saved retry policy vanished on refresh even though the write path was correct.

Get.cs and Search.cs never mapped RetryPolicyId/CustomRetryPolicy onto
the response, so a saved retry policy vanished on refresh even though
the write path was correct.
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Subscription get and search responses now include RetryPolicyId and CustomRetryPolicy values sourced from the retrieved subscription entity.

Changes

Subscription retry policy fields

Layer / File(s) Summary
Populate retry policy response fields
SW.Bitween.Api/Resources/Subscriptions/Get.cs, SW.Bitween.Api/Resources/Subscriptions/Search.cs
Get and search projections now populate RetryPolicyId and CustomRetryPolicy from the subscription entity without changing existing query or response control flow.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: risk:medium

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states the main change: returning retry policy fields from subscription Get/Search.
Description check ✅ Passed The description matches the code changes by noting the missing retry policy fields on Get/Search responses.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MusaMisto MusaMisto closed this Jul 22, 2026
@MusaMisto MusaMisto reopened this Jul 22, 2026
@hamzahalq
hamzahalq merged commit 70a96aa into releases/r8.0 Jul 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants