Fix/normalized tables type bug #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Changes database schema to fix typing issues in workflow block positioning by converting position_x, position_y, and height columns from integer to numeric type in the workflow_blocks table.
- Modifies
apps/sim/db/schema.tsto use decimal types for positionX, positionY and height fields - Updates
apps/sim/lib/workflows/db-helpers.tsto properly convert between string DB fields and numeric application values - Adds migration
0044_uneven_killer_shrike.sqlto safely convert existing data to new numeric format - Sets default value of '0' for height column to ensure data consistency
5 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
| ALTER TABLE "workflow_blocks" ALTER COLUMN "position_x" SET DATA TYPE numeric;--> statement-breakpoint | ||
| ALTER TABLE "workflow_blocks" ALTER COLUMN "position_y" SET DATA TYPE numeric;--> statement-breakpoint | ||
| ALTER TABLE "workflow_blocks" ALTER COLUMN "height" SET DATA TYPE numeric;--> statement-breakpoint | ||
| ALTER TABLE "workflow_blocks" ALTER COLUMN "height" SET DEFAULT '0'; |
There was a problem hiding this comment.
logic: Using string '0' as default for numeric column is inconsistent. Should be numeric literal 0 without quotes
Suggested change
| ALTER TABLE "workflow_blocks" ALTER COLUMN "height" SET DEFAULT '0'; | |
| ALTER TABLE "workflow_blocks" ALTER COLUMN "height" SET DEFAULT 0; |
Comment on lines
+134
to
+135
| positionX: String(block.position?.x || 0), | ||
| positionY: String(block.position?.y || 0), |
There was a problem hiding this comment.
style: Position values should be rounded before String conversion to prevent floating point precision issues
added 2 commits
June 19, 2025 15:50
…ai/sim into fix/normalized-tables-type-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typing change to fix lint.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist:
bun run test)Security Considerations:
Additional Information:
Any additional information, configuration or data that might be necessary to reproduce the issue or use the feature.