generated from allen-cell-animated/github-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/3rd module #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/3rd module #208
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
4753a11
make indicator clickable
meganrm c5f2deb
switch module and save which have been completed
meganrm fe0c926
add pop confirm
meganrm e54b3e1
Update src/components/PageIndicator.tsx
meganrm ad535ef
type index as number
meganrm 2d25fe0
Merge branch 'feature/navigation' of https://github.com/simularium/bi…
meganrm 9a87d17
add key
meganrm 57a2de7
make sure index is a number
meganrm 59cdf1f
use a set for completed modules
meganrm 21dab42
show cursor
meganrm 13a1254
Merge branch 'main' into feature/navigation
meganrm 16e1b16
fix merge conflict
meganrm e425c5e
fix merge conflict
meganrm a25115d
Update src/components/PageIndicator.tsx
meganrm b9f55f1
clean up css
meganrm b22c34d
Merge branch 'feature/navigation' of https://github.com/simularium/bi…
meganrm ee64742
display adjustments
meganrm a2e517a
add competitive content
meganrm 57dada6
remove unused imports
meganrm d6b35c8
change data structure
meganrm e4c3d4a
use type id
meganrm a85f67b
content adjustments
meganrm 4c17e56
Merge branch 'main' of https://github.com/simularium/binding-sim-edu …
meganrm 8064b34
change vis control
meganrm b1a4989
remove log
meganrm 060b30e
lift state up
meganrm b270d35
Update src/content/Competitive.tsx
meganrm c39141d
Update src/App.tsx
meganrm 52a6650
changes based on comments
meganrm 800f22f
changes based on comments
meganrm 4806e87
write logic consistently
meganrm 1fd19ae
add comment
meganrm e02a457
fix error
meganrm 7fe65d5
fix ic50
meganrm 59193e7
Update src/simulation/BindingSimulator2D.ts
meganrm 07698c9
Merge branch 'feature/3rd-module' of https://github.com/simularium/bi…
meganrm abe6556
remove duplicate call
meganrm 3e0de31
add comment and error check
meganrm 142f897
Update src/simulation/BindingSimulator2D.ts
meganrm ec81d10
more explicit checks
meganrm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The conditional formatting logic for decimal marks is unclear and fragile. Consider extracting this to a named function with a descriptive name like
formatSliderMarkto improve readability and make the intent explicit.