Feature/use widget in colab #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jupyter notebook, and google colab
…ss, but this is gross so I gotta come up with a better way
ascibisz
commented
Dec 18, 2024
Contributor
Author
There was a problem hiding this comment.
This file contains what used to be in src/widget.ts, with some changes to use anywidget
ascibisz
commented
Dec 18, 2024
…ed for that purpose used in Viewer.tsx
ascibisz
requested review from
frasercl,
interim17 and
meganrm
and removed request for
a team
interim17
approved these changes
Jan 8, 2025
Contributor
interim17
left a comment
interim17
left a comment
There was a problem hiding this comment.
Awesome that we can run in jupyter notebook as well as colab now
meganrm
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time Estimate or Size
Medium
Problem
Previously, the nbsv widget only works in Jupyterlab, but it would be ideal if it works in Google Collab (and Jupyter Notebook while we're at it)
Link to story or ticket
Solution
After fumbling with debugging for a long time, I discovered the anywidget package which is meant to handle a lot of the platform specific configurations, allowing widgets that use it to work on multiple different platforms. This allowed me to get rid of some of the weird configurations I was trying to use to get rid of errors in google colab!
Type of change