Skip to content

Conversation

@interim17
Copy link
Contributor

@interim17 interim17 commented Nov 18, 2024

Time Estimate or Size

either tiny or the largest ever

@frasercl proposed that the formatter printWidth be bumped from 80 to 120

That's a one line change.

However, it means that every time a file gets edited in the future, that PR is likely to contain extra formatting changes. We could just do it all at once instead.

So I ran prettier --write "." to format the whole repo with the new rule, that's why this PR is:
19,885 additions and 8,319 deletions

Either we trust that these are just formatting changes and assume that: printWidth: 120 is the only piece that needs real review, or I will do a different PR with only the config change, and we can let the process of reformatting the repo happen gradually over time. Thoughts?

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 42.38% 2160/5097
🔴 Branches 45.03% 910/2021
🔴 Functions 38.98% 451/1157
🔴 Lines 42.62% 2071/4859

Test suite run success

144 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from 377513f

@interim17 interim17 closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants