Skip to content

add export field to package.json #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
interim17 merged 6 commits into from
Jul 31, 2025
Merged

add export field to package.json #496

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
69468b3
add export field to package.json
interim17 Jun 10, 2025
20a3b6d
import stylesheet index.ts
interim17 Jun 11, 2025
3a6c82c
move stylesheet import up one level
interim17 Jun 11, 2025
3eb1b66
don't procses css in vitest
interim17 Jun 11, 2025
640d041
take style directory out of copy-build step
interim17 Jul 22, 2025
ab61007
remove top level stylesheet duplication restore exports field
interim17 Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"generateTypes": "tsc -p tsconfig.base.json --emitDeclarationOnly",
"transpileES": "cross-env TS_NODE_PROJECT=tsconfig.es.json BABEL_ENV=es babel src --out-dir es --extensions .ts,.tsx,.js,.jsx --ignore 'src/test'",
"processCSS": "postcss src/viewport/index.css --output es/style/style.css",
"copy-build": "copyfiles 'es/**/*' style/* 'type-declarations/**/*' package.json README.md dev-build",
"copy-build": "copyfiles 'es/**/*' 'type-declarations/**/*' package.json README.md dev-build",
"gh-build": "npm run processCSS && cd examples && npm run build-example",
"lint": "eslint src/**",
"test": "vitest run",
Expand All @@ -28,7 +28,6 @@
},
"files": [
"es",
"style",
"type-declarations",
"README.md",
"package.json"
Expand All @@ -41,6 +40,10 @@
"type": "git",
"url": "https://github.com/simularium/simularium-viewer.git"
},
"exports": {
".": "./es/index.js",
"./style/style.css": "./es/style/style.css"
Copy link
Contributor

@toloudis toloudis Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this makes me wonder if you could have the same effect if you just had one single export alias from "." to "./es"

Copy link
Contributor Author

@interim17 interim17 Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible, and I could test that if you like, but I think that would allow importing from everything in /es rather than just the stuff we choose to expose in index.js?

Copy link
Contributor

@toloudis toloudis Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, then in that case I think I like your fix as is, assuming it works in all the cases we care about! Or if @meganrm has any better ideas

},
"author": "",
"license": "MIT",
"devDependencies": {
Expand Down
Loading