Skip to content

Conversation

@ascibisz
Copy link
Contributor

Time Estimate or Size

xsmall

Problem

Binary files are failing to run when we press "play", but are working to just step through each frame
Part of this ticket

Solution

When decoding the binary frame data, read the frameNumber as an int instead of a float

@github-actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.15% 2583 / 11658
🔵 Statements 22.15% 2583 / 11658
🔵 Functions 25% 149 / 596
🔵 Branches 80.41% 349 / 434
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/simularium/VisData.ts 50% 60% 55.55% 50% 23-37, 50-51, 54-55, 58-59, 72-79, 90-94, 110-112, 122-123, 140-148, 152, 154-156, 162-168, 177-183, 191, 193-195, 200-206
Generated in workflow #618 for commit 4153f06 by the Vitest Coverage Report Action

@ascibisz ascibisz marked this pull request as ready for review August 13, 2025 21:27
@ascibisz ascibisz requested a review from a team as a code owner August 13, 2025 21:27
@ascibisz ascibisz requested review from ShrimpCryptid, interim17 and meganrm and removed request for a team and ShrimpCryptid August 13, 2025 21:27
@ascibisz ascibisz merged commit 4527126 into main Aug 15, 2025
6 checks passed
@ascibisz ascibisz deleted the bug/fix-binary-stream branch August 15, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants