generated from allen-cell-animated/github-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 2
fix: agent paths bug #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: agent paths bug #509
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -1830,16 +1830,23 @@ class VisGeometry { | |||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| public removePathForAgent(id: number): void { | ||||||||||||||
| if (!this.agentPaths.delete(id)) { | ||||||||||||||
| const path = this.agentPaths.get(id); | ||||||||||||||
| if (!path) { | ||||||||||||||
| this.logger.warn( | ||||||||||||||
| "attempted to remove path for agent " + | ||||||||||||||
| id + | ||||||||||||||
| " that doesn't exist." | ||||||||||||||
| ); | ||||||||||||||
| return; | ||||||||||||||
| } | ||||||||||||||
| this.agentPathGroup.remove(path.line); | ||||||||||||||
| this.agentPaths.delete(id); | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| private removeAllPaths() { | ||||||||||||||
| this.agentPaths.forEach((path) => { | ||||||||||||||
| this.agentPathGroup.remove(path.line); | ||||||||||||||
| }); | ||||||||||||||
|
Comment on lines
+1847
to
+1849
|
||||||||||||||
| this.agentPaths.forEach((path) => { | |
| this.agentPathGroup.remove(path.line); | |
| }); | |
| for (const path of this.agentPaths.values()) { | |
| this.agentPathGroup.remove(path.line); | |
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between agentPathGroup and agentPaths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the agentPaths are the line data and the group paths are the threeJS objects associated with that data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agentPathGroup is a threejs Group object which is just a parent node for all the paths to belong to. agentPaths is a mapping of agent id to path, for all current agents that are drawing paths.