fix typing on styled components v6 theme and props #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interim17
requested review from
meganrm and
tyler-foster
and removed request for
a team
Coverage report
Test suite run success137 tests passing in 8 suites. Report generated by 🧪jest coverage report action from 3993ccd |
toloudis
approved these changes
Jun 10, 2025
ascibisz
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time estimate or Size
small
Problem
Import resolution of viewer stylesheet is broken, for some reason the fix in the viewer triggered breaking changes related the typing of the
styled-componentstheme.Viewer fix PR
simularium/simularium-viewer#496
Solution
Remove
@types/styled-componentsbecause v6 is TS native.Remove
DefaultTheme, export our ownThemedPropstype for use in styled components.This will be broken until patched with the new viewer.